Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New substrate event ExecutedFromXcm to link xcm message hash with ethereum tx hash #2874

Merged
merged 4 commits into from
Jul 25, 2024
Merged

New substrate event ExecutedFromXcm to link xcm message hash with ethereum tx hash #2874

merged 4 commits into from
Jul 25, 2024

Conversation

librelois
Copy link
Collaborator

@librelois librelois commented Jul 25, 2024 •
edited
Loading

What does it do?

Add a substrate event ethereumXcm.ExecutedFromXcm(xcmMsgHash, ethTxHash) that map ethereum transaction hash with an XCM message hash if the execution was triggered from XCM.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@librelois librelois added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Jul 25, 2024
@librelois librelois changed the title New event to link xcm message hash with ethereum tx hash New substrate event ExecutedFromXcm to link xcm message hash with ethereum tx hash Jul 25, 2024
@librelois librelois marked this pull request as ready for review July 25, 2024 09:21
@noandrea noandrea mentioned this pull request Jul 25, 2024
Closed
22 tasks
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

@@                   Coverage Diff                    @@
##           master   ellois-eth-xcm-event      +/-   ##
========================================================
- Coverage   81.01%                 80.88%   -0.13%     
+ Files         274                    281       +7     
+ Lines       80830                  81698     +868     
========================================================
+ Hits        65483                  66075     +592     
+ Misses      15347                  15623     +276
Files Changed Coverage
/pallets/ethereum-xcm/src/lib.rs 79.55% (-5.23%) 🔽
/precompiles/assets-erc20/src/lib.rs 97.73% (+0.29%) 🔼
/primitives/xcm/src/ethereum_xcm.rs 97.20% (+2.93%) 🔼
/runtime/common/src/impl_moonbeam_xcm_call_tracing.rs 31.25% (+31.25%) 🔼
/runtime/common/src/impl_xcm_evm_runner.rs 58.65% (+58.65%) 🔼
/runtime/moonbase/src/asset_config.rs 47.06% (-2.94%) 🔽
/runtime/moonbase/src/lib.rs 52.71% (-0.74%) 🔽
/runtime/moonbase/src/xcm_config.rs 64.00% (+9.65%) 🔼
/runtime/moonbase/tests/common/mod.rs 97.07% (-0.31%) 🔽
/runtime/moonbase/tests/integration_test.rs 99.37% (-0.03%) 🔽
/runtime/moonbeam/src/lib.rs 47.14% (-0.15%) 🔽

Coverage generated Thu Jul 25 13:46:52 UTC 2024

@librelois librelois requested a review from Agusrodri July 25, 2024 14:37
@noandrea noandrea merged commit 3db6b5c into master Jul 25, 2024
37 checks passed
@noandrea noandrea deleted the ellois-eth-xcm-event branch July 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agusrodri Agusrodri Agusrodri approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@librelois @Agusrodri @noandrea